Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 455003002: Omnibox: Clobber HQP Cache File when user mucks with history (Closed)

Created:
6 years, 4 months ago by Mark P
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Omnibox: Clobber HQP Cache File when user mucks with history TBR=sky (as usual for omnibox HistoryQuick provider stuff) Test: see repro steps on bug. BUG=400940 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/history/in_memory_url_index.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mark P
As discussed. Please take a look. thanks, mark
6 years, 4 months ago (2014-08-08 19:25:24 UTC) #1
Peter Kasting
LGTM The new comment seems a little repetitive in its verbosity, but I don't have ...
6 years, 4 months ago (2014-08-08 20:22:02 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 4 months ago (2014-08-08 20:24:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/455003002/1
6 years, 4 months ago (2014-08-08 20:25:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-09 01:53:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-09 02:00:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3116)
6 years, 4 months ago (2014-08-09 02:00:11 UTC) #7
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 4 months ago (2014-08-09 03:25:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/455003002/1
6 years, 4 months ago (2014-08-09 03:27:39 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 05:46:11 UTC) #10
Message was sent while issue was closed.
Change committed as 288515

Powered by Google App Engine
This is Rietveld 408576698