fpdfsdk/src/fpdfsave.cpp - Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfsave.cpp

Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: mark m_FileAccess private. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fpdfsave.cpp

diff --git a/fpdfsdk/src/fpdfsave.cpp b/fpdfsdk/src/fpdfsave.cpp

index 8025946ba8e589bfc7bb14b40f34bbb5f94b5c89..45dfbf7214eca15784b3a18c0ae6820e2215301c 100644

--- a/fpdfsdk/src/fpdfsave.cpp

+++ b/fpdfsdk/src/fpdfsave.cpp

@@ -19,8 +19,8 @@ class CFX_IFileWrite FX_FINAL : public IFX_StreamWrite

public:

CFX_IFileWrite();

FX_BOOL Init( FPDF_FILEWRITE * pFileWriteStruct );

- virtual FX_BOOL WriteBlock(const void* pData, size_t size);

- virtual void Release(){};

+ virtual FX_BOOL WriteBlock(const void* pData, size_t size) FX_OVERRIDE;

+ virtual void Release() FX_OVERRIDE {}

protected:

FPDF_FILEWRITE* m_pFileWriteStruct;

« no previous file with comments | « fpdfsdk/src/fpdf_sysfontinfo.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »