Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: fpdfsdk/include/fsdk_define.h

Issue 454983003: Add FX_OVERRIDE and use it for virtual functions of FX_FINAL classes. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Add FX_OVERRIDE and remove unused members. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef _FPDFSDK_DEFINE_H 7 #ifndef _FPDFSDK_DEFINE_H
8 #define _FPDFSDK_DEFINE_H 8 #define _FPDFSDK_DEFINE_H
9 9
10 #ifdef _WIN32 10 #ifdef _WIN32
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 typedef unsigned int FX_UINT; 100 typedef unsigned int FX_UINT;
101 101
102 #include "fpdfview.h" 102 #include "fpdfview.h"
103 103
104 class CPDF_CustomAccess FX_FINAL : public IFX_FileRead, public CFX_Object 104 class CPDF_CustomAccess FX_FINAL : public IFX_FileRead, public CFX_Object
105 { 105 {
106 public: 106 public:
107 CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess); 107 CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess);
108 ~CPDF_CustomAccess() {} 108 ~CPDF_CustomAccess() {}
109 109
110 » virtual CFX_ByteString GetFullPath() { return ""; } 110 » virtual FX_FILESIZE» GetSize() FX_OVERRIDE { return m_FileAccess.m_Fi leLen; }
111 » virtual FX_FILESIZE» GetSize() { return m_FileAccess.m_FileLen; }
112 111
113 » virtual FX_BOOL»» GetByte(FX_DWORD pos, FX_BYTE& ch); 112 » virtual void» » Release() FX_OVERRIDE { delete this; }
jun_fang 2014/08/08 22:16:40 Shall we consider to remove delete this from pdfiu
Tom Sepez 2014/08/08 22:21:36 Maybe later.
114 » virtual FX_BOOL»» GetBlock(FX_DWORD pos, FX_LPBYTE pBuf, FX_DWORD size);
115 » virtual void» » Release() { delete this; }
116 113
117 » virtual FX_BOOL»» ReadBlock(void* buffer, FX_FILESIZE offset, size _t size); 114 » virtual FX_BOOL»» ReadBlock(void* buffer, FX_FILESIZE offset, size _t size) FX_OVERRIDE;
118 115
119 FPDF_FILEACCESS m_FileAccess; 116 FPDF_FILEACCESS m_FileAccess;
120 FX_BYTE m_Buffer[512];
121 FX_DWORD m_BufferOffset;
122 }; 117 };
123 118
124 void FSDK_SetSandBoxPolicy(FPDF_DWORD policy, FPDF_BOOL enable); 119 void FSDK_SetSandBoxPolicy(FPDF_DWORD policy, FPDF_BOOL enable);
125 FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy); 120 FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy);
126 121
127 122
128 #endif//_FPDFSDK_DEFINE_H 123 #endif//_FPDFSDK_DEFINE_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698