Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 454983002: [Android] Check if enhanced bookmarks id is set by finch. (Closed)

Created:
6 years, 4 months ago by Kibeom Kim (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Yaron, sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Check if enhanced bookmarks id is set by finch. BUG=401921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289265

Patch Set 1 #

Total comments: 2

Patch Set 2 : const #

Patch Set 3 : fix mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kibeom Kim (inactive)
6 years, 4 months ago (2014-08-08 19:12:36 UTC) #1
Yaron
lgtm
6 years, 4 months ago (2014-08-08 20:10:01 UTC) #2
Kibeom Kim (inactive)
sky@: ping? (owner)
6 years, 4 months ago (2014-08-12 23:10:09 UTC) #3
sky
LGTM https://codereview.chromium.org/454983002/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc File chrome/browser/bookmarks/enhanced_bookmarks_features.cc (right): https://codereview.chromium.org/454983002/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc#newcode31 chrome/browser/bookmarks/enhanced_bookmarks_features.cc:31: std::string ext_id = GetEnhancedBookmarksExtensionIdFromFinch(); nit: const
6 years, 4 months ago (2014-08-12 23:17:21 UTC) #4
Kibeom Kim (inactive)
https://codereview.chromium.org/454983002/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc File chrome/browser/bookmarks/enhanced_bookmarks_features.cc (right): https://codereview.chromium.org/454983002/diff/1/chrome/browser/bookmarks/enhanced_bookmarks_features.cc#newcode31 chrome/browser/bookmarks/enhanced_bookmarks_features.cc:31: std::string ext_id = GetEnhancedBookmarksExtensionIdFromFinch(); On 2014/08/12 23:17:21, sky wrote: ...
6 years, 4 months ago (2014-08-12 23:33:38 UTC) #5
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 4 months ago (2014-08-12 23:33:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/454983002/40001
6 years, 4 months ago (2014-08-12 23:52:47 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 09:04:05 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 11:25:57 UTC) #9
Message was sent while issue was closed.
Change committed as 289265

Powered by Google App Engine
This is Rietveld 408576698