Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 454953002: rebaseline_server: periodically log tasks_queue size (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
stephana, rmistry
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rebaseline_server: periodically log tasks_queue size Without this, it's hard to tell whether the server is stuck (or why it's taking so long). NOTRY=true Committed: https://skia.googlesource.com/skia/+/9c7695b0b59b97da933cd11014c922344a8d7654

Patch Set 1 #

Total comments: 2

Patch Set 2 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M gm/rebaseline_server/compare_rendered_pictures.py View 2 chunks +6 lines, -0 lines 0 comments Download
M gm/rebaseline_server/imagediffdb.py View 1 5 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
epoger
Stephan, PTAL (please take a look) at patchset 1. Here's sample output: 08/08/2014 14:27:57 INFO ...
6 years, 4 months ago (2014-08-08 18:35:19 UTC) #1
stephana
https://codereview.chromium.org/454953002/diff/1/gm/rebaseline_server/imagediffdb.py File gm/rebaseline_server/imagediffdb.py (right): https://codereview.chromium.org/454953002/diff/1/gm/rebaseline_server/imagediffdb.py#newcode301 gm/rebaseline_server/imagediffdb.py:301: This is a nit, but why do you need ...
6 years, 4 months ago (2014-08-11 13:35:18 UTC) #2
epoger
Thanks, Stephan... https://codereview.chromium.org/454953002/diff/1/gm/rebaseline_server/imagediffdb.py File gm/rebaseline_server/imagediffdb.py (right): https://codereview.chromium.org/454953002/diff/1/gm/rebaseline_server/imagediffdb.py#newcode301 gm/rebaseline_server/imagediffdb.py:301: On 2014/08/11 13:35:18, stephana wrote: > This ...
6 years, 4 months ago (2014-08-11 18:49:09 UTC) #3
stephana
On 2014/08/11 18:49:09, epoger wrote: > Thanks, Stephan... > > https://codereview.chromium.org/454953002/diff/1/gm/rebaseline_server/imagediffdb.py > File gm/rebaseline_server/imagediffdb.py (right): ...
6 years, 4 months ago (2014-08-11 19:27:03 UTC) #4
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-12 15:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/454953002/20001
6 years, 4 months ago (2014-08-12 15:28:58 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-12 15:28:59 UTC) #7
rmistry
LGTM I need to add Stephen to the Skia committers list.
6 years, 4 months ago (2014-08-12 15:29:46 UTC) #8
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 4 months ago (2014-08-12 15:29:58 UTC) #9
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-12 15:29:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/454953002/20001
6 years, 4 months ago (2014-08-12 15:30:03 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:30:15 UTC) #12
Message was sent while issue was closed.
Change committed as 9c7695b0b59b97da933cd11014c922344a8d7654

Powered by Google App Engine
This is Rietveld 408576698