Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 454933003: [rebaseline.py] Quit LogToServer thread immediately on exception (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index c25c8ede184e2af8a73c77527a66c8cb07029ccd..c7bf0bcb0850a6a4043118e24321731dec465e72 100644
--- a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -922,10 +922,12 @@ class RebaselineOMatic(AbstractDeclarativeCommand):
rebaseline_command.append('--verbose')
self._run_logged_command(rebaseline_command)
except:
+ self._log_queue.put(self.QUIT_LOG)
traceback.print_exc(file=sys.stderr)
# Sometimes git crashes and leaves us on a detached head.
self._tool.scm().checkout_branch(old_branch_name)
- self._log_queue.put(self.QUIT_LOG)
+ else:
+ self._log_queue.put(self.QUIT_LOG)
log_thread.join()
def execute(self, options, args, tool):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698