Issue 454933003: [rebaseline.py] Quit LogToServer thread immediately on exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454933003: [rebaseline.py] Quit LogToServer thread immediately on exception (Closed)

Created:
6 years, 4 months ago by Xianzhu

Modified:
6 years, 4 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[rebaseline.py] Quit LogToServer thread immediately on exception Send QUIT_LOG to LogToServer thread immediately on exception to avoid blocking. We still need to press ctrl-c twice to quit the whole rebaseline-o-matic script. This is intended because we want the first ctrl-c to break the current rebaseline, and the second to break the outer loop. This also ensures that the loop continues on any temporary exception raised during a rebaseline. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179869