Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 454893003: Show error message on attempt to load old Timeline data into tracing based Timeline (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Show error message on attempt to load old Timeline data into tracing based Timeline BUG=401953 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M Source/devtools/front_end/timeline/TracingModel.js View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 2 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 4 months ago (2014-08-08 14:39:00 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-08 14:51:37 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-11 07:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/454893003/1
6 years, 4 months ago (2014-08-11 07:07:32 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 08:04:03 UTC) #5
Message was sent while issue was closed.
Change committed as 179916

Powered by Google App Engine
This is Rietveld 408576698