Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 454873006: DevTools: Fix "documentation" module code style (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
Reviewers:
iliia, semeny, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix "documentation" module code style R=iliia, semeny, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179936

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -153 lines) Patch
M LayoutTests/inspector/documentation/document-parser-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/documentation/CSSArticle.js View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/front_end/documentation/DocumentationURLProvider.js View 3 chunks +9 lines, -7 lines 0 comments Download
M Source/devtools/front_end/documentation/JSArticle.js View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/documentation/WikiParser.js View 5 chunks +130 lines, -122 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
apavlov
6 years, 4 months ago (2014-08-08 16:58:02 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-08-11 07:14:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/454873006/1
6 years, 4 months ago (2014-08-11 07:15:26 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 08:25:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 08:52:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/19973)
6 years, 4 months ago (2014-08-11 08:52:13 UTC) #6
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-11 10:09:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/454873006/20001
6 years, 4 months ago (2014-08-11 10:10:04 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 11:21:55 UTC) #9
Message was sent while issue was closed.
Change committed as 179936

Powered by Google App Engine
This is Rietveld 408576698