Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 454873005: Move UpdateManifest to //extensions (Closed)

Created:
6 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move UpdateManifest to //extensions This just moves update_manifest.h/cc into the extensions_common target. Precursor to moving manifest parsing code and ultimately the rest of the download/install/update code. BUG=398671 TBR=dcheng@chromium.org for IPC messages (header move only) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -392 lines) Patch
M chrome/browser/extensions/updater/extension_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/safe_manifest_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_utility_extensions_messages.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/update_manifest.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/common/extensions/update_manifest.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M chrome/common/extensions/update_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/common/update_manifest.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/update_manifest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
Ben please take a look.
6 years, 4 months ago (2014-08-08 16:06:07 UTC) #1
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-08 16:44:39 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 4 months ago (2014-08-08 17:27:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/454873005/1
6 years, 4 months ago (2014-08-08 17:28:17 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 21:07:10 UTC) #5
Message was sent while issue was closed.
Change committed as 288430

Powered by Google App Engine
This is Rietveld 408576698