Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 454853002: Fixing UnboundLocalError: local variable 'timestamp' in manager.py (Closed)

Created:
6 years, 4 months ago by patro
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke, vivekg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixing UnboundLocalError: local variable 'timestamp' in manager.py The try except block in _rename_results_folder() is throwing an UnboundLocalError. Because the return statement in except block is inside if statement. If the condition is false the function doesnot return which throws an error so the return statement must be outside the if statement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
patro
Kindly Review Thanks and Regards, Shyam
6 years, 4 months ago (2014-08-08 09:36:54 UTC) #1
Dirk Pranke
lgtm
6 years, 4 months ago (2014-08-08 19:23:25 UTC) #2
patro
The CQ bit was checked by behara.ms@samsung.com
6 years, 4 months ago (2014-08-09 06:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/behara.ms@samsung.com/454853002/1
6 years, 4 months ago (2014-08-09 06:20:57 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 06:36:09 UTC) #5
Message was sent while issue was closed.
Change committed as 179884

Powered by Google App Engine
This is Rietveld 408576698