cc/resources/raster_buffer.h - Issue 454843002: cc: Do bitmap conversion for RasterBuffer in the worker thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/resources/raster_buffer.h

Issue 454843002: cc: Do bitmap conversion for RasterBuffer in the worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed RasterBuffer interface. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_RESOURCES_RASTER_BUFFER_H_

	6 #define CC_RESOURCES_RASTER_BUFFER_H_

	7

	8 class SkCanvas;

	9

	10 namespace cc {

	11

	12 class RasterBuffer {

	13 public:

	14 virtual SkCanvas* AcquireSkCanvas() = 0;

	15 virtual void ReleaseSkCanvas() = 0;
	reveman 2014/08/12 14:31:26 nit: maybe require the SkCanvas* to be passed to R nit: maybe require the SkCanvas* to be passed to ReleaseSkCanvas() so that an implementation that is not interested in caching the canvas can just unref it there instead of keeping an internal ref to it. auygun 2014/08/13 14:18:53 Acknowledged. Show quoted text On 2014/08/12 14:31:26, reveman wrote: > nit: maybe require the SkCanvas* to be passed to ReleaseSkCanvas() so that an > implementation that is not interested in caching the canvas can just unref it > there instead of keeping an internal ref to it. Acknowledged.
	16

	17 protected:

	18 virtual ~RasterBuffer() {}

	19 };

	20

	21 } // namespace cc

	22

	23 #endif // CC_RESOURCES_RASTER_BUFFER_H_

OLD	NEW

« no previous file with comments | « cc/resources/pixel_buffer_raster_worker_pool.cc ('k') | cc/resources/raster_worker_pool_perftest.cc » ('j') | cc/resources/rasterizer.h » ('J')