Source/bindings/core/v8/PrivateScriptRunner.js - Issue 454773002: Blink-in-JS: Support private scripts in partial interfaces (PrivateScriptRunner part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PrivateScriptRunner.js

Issue 454773002: Blink-in-JS: Support private scripts in partial interfaces (PrivateScriptRunner part) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/PrivateScriptRunner.cpp ('K') | « Source/bindings/core/v8/PrivateScriptRunner.cpp ('k') | Source/build/scripts/make_private_script_source.py » ('j') | Source/core/core_generated.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/PrivateScriptRunner.js

diff --git a/Source/bindings/core/v8/PrivateScriptRunner.js b/Source/bindings/core/v8/PrivateScriptRunner.js

index 0baab26b2ba49017ea9b8f826d860d8373e6c17c..75c7e9bd2d6bf32d9435f2996207e23496ae7ba1 100644

--- a/Source/bindings/core/v8/PrivateScriptRunner.js

+++ b/Source/bindings/core/v8/PrivateScriptRunner.js

@@ -82,7 +82,8 @@ function privateScriptClass()

function installClass(className, implementation)

{

- installedClasses[className] = new privateScriptClass();

+ if (installedClasses[className] === undefined)

Jens Widell 2014/08/11 12:27:57 "!(className in installedClasses)" would be a more

haraken 2014/08/11 12:41:40 Done.

+ installedClasses[className] = new privateScriptClass();

implementation(window, installedClasses[className]);

}