Issue 454693004: Skip gmock and gtest in presubmit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454693004: Skip gmock and gtest in presubmit. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/presubmit.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

PTAL. Not so nice that this skips relative path chunks without context. But I guess ...

6 years, 4 months ago (2014-08-11 13:52:55 UTC) #1

Michael Achenbach

6 years, 4 months ago (2014-08-11 14:07:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23044 (presubmit successful).