Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: Source/core/rendering/compositing/CompositedSelectionBound.h

Issue 454643002: Route selection bounds updates through WebLayerTreeView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: tests added Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositedSelectionBound.h
diff --git a/Source/platform/fonts/FontPlatformFeatures.h b/Source/core/rendering/compositing/CompositedSelectionBound.h
similarity index 77%
copy from Source/platform/fonts/FontPlatformFeatures.h
copy to Source/core/rendering/compositing/CompositedSelectionBound.h
index b2feda2d8bcc65ab02f02438d56037c27e5c2e7d..85d85b310fd96283af913dc5c90f263efaf6e380 100644
--- a/Source/platform/fonts/FontPlatformFeatures.h
+++ b/Source/core/rendering/compositing/CompositedSelectionBound.h
@@ -28,20 +28,31 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef FontPlatformFeatures_h
-#define FontPlatformFeatures_h
+#ifndef CompositedSelectionBound_h
+#define CompositedSelectionBound_h
-#include "platform/PlatformExport.h"
+#include "platform/geometry/FloatPoint.h"
+#include "platform/graphics/GraphicsLayer.h"
namespace blink {
-class FontPlatformFeatures {
-public:
- static bool canReturnFallbackFontsForComplexText();
- static bool canExpandAroundIdeographsInComplexText();
+struct CompositedSelectionBound {
+ enum Type {
+ Caret,
+ SelectionLeft,
+ SelectionRight
+ };
-private:
- FontPlatformFeatures();
+ CompositedSelectionBound()
+ : type(Caret)
+ , layer(nullptr)
+ {
+ }
+
+ Type type;
+ GraphicsLayer* layer;
+ FloatPoint edgeTopInLayer;
chrishtr 2014/09/05 22:14:56 Why isn't it just a rect?
jdduke (slow) 2014/09/05 22:18:33 We used a rect in the past, but abandoned it in fa
chrishtr 2014/09/05 22:39:26 Line segment doesn't exist. What does edgeTop act
jdduke (slow) 2014/09/05 23:30:45 Yes.
chrishtr 2014/09/05 23:45:28 I see. Then I suggest the names "edgeTop" and "edg
+ FloatPoint edgeBottomInLayer;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698