Route selection bounds updates through WebLayerTreeView

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 15 matching lines @@
 
 #include "config.h"
 #include "core/frame/FrameView.h"
 
 #include "core/HTMLNames.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/css/FontFaceSet.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/DocumentMarkerController.h"
 #include "core/editing/FrameSelection.h"
+#include "core/editing/RenderedPosition.h"
 #include "core/events/OverflowEvent.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/fetch/ResourceLoadPriorityOptimizer.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLFrameElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/parser/TextResourceDecoder.h"
 #include "core/inspector/InspectorInstrumentation.h"
@@ skipping 12 matching lines @@
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderListBox.h"
 #include "core/rendering/RenderPart.h"
 #include "core/rendering/RenderScrollbar.h"
 #include "core/rendering/RenderScrollbarPart.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/rendering/RenderView.h"
 #include "core/rendering/RenderWidget.h"
 #include "core/rendering/TextAutosizer.h"
 #include "core/rendering/compositing/CompositedLayerMapping.h"
+#include "core/rendering/compositing/CompositedSelectionBound.h"
 #include "core/rendering/compositing/RenderLayerCompositor.h"
 #include "core/rendering/style/RenderStyle.h"
 #include "core/rendering/svg/RenderSVGRoot.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGSVGElement.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/TraceEvent.h"
 #include "platform/fonts/FontCache.h"
 #include "platform/geometry/FloatRect.h"
@@ skipping 1485 matching lines @@
         RenderLayer* layer = toRenderBoxModelObject(renderer)->layer();
 
         // Don't need to do this for composited fixed items.
         if (layer->compositingState() == PaintsIntoOwnBacking)
             continue;
 
         layer->paintInvalidator().computePaintInvalidationRectsIncludingNonCompositingDescendants();
     }
 }
 
+static bool computeCompositedSelectionBounds(LocalFrame& frame, CompositedSelectionBound& start, CompositedSelectionBound& end)

[chrishtr, 2014/09/05 22:14:56]

Make this a static member method of FrameView.

[trchen, 2014/09/06 00:06:26]

Acknowledged.

+{
+    const VisibleSelection &selection = frame.selection().selection();
+    if (!selection.isCaretOrRange())
+        return false;
+
+    VisiblePosition visibleStart(selection.visibleStart());
+    VisiblePosition visibleEnd(selection.visibleEnd());
+
+    RenderedPosition renderedStart(visibleStart);
+    RenderedPosition renderedEnd(visibleEnd);
+    FloatPoint edgeTop, edgeBottom;
+
+    renderedStart.layerPoints(start.layer, start.edgeTopInLayer, start.edgeBottomInLayer);
+    renderedEnd.layerPoints(end.layer, end.edgeTopInLayer, end.edgeBottomInLayer);
+
+    if (selection.isCaret()) {
+        start.type = end.type = CompositedSelectionBound::Caret;
+        return true;
+    }
+
+    TextDirection startDir = visibleStart.deepEquivalent().primaryDirection();
+    TextDirection endDir = visibleEnd.deepEquivalent().primaryDirection();
+    start.type = startDir == RTL ? CompositedSelectionBound::SelectionRight : CompositedSelectionBound::SelectionLeft;
+    end.type = endDir == RTL ? CompositedSelectionBound::SelectionLeft : CompositedSelectionBound::SelectionRight;
+    return true;
+}
+
 void FrameView::updateCompositedSelectionBoundsIfNeeded()
 {
     if (!RuntimeEnabledFeatures::compositedSelectionUpdatesEnabled())
         return;
 
     Page* page = frame().page();
     ASSERT(page);
 
+    CompositedSelectionBound start, end;
     LocalFrame* frame = toLocalFrame(page->focusController().focusedOrMainFrame());
-    if (!frame || !frame->selection().isCaretOrRange()) {
+    if (!frame || !computeCompositedSelectionBounds(*frame, start, end)) {
         page->chrome().client().clearCompositedSelectionBounds();
         return;
     }
 
-    // TODO(jdduke): Compute and route selection bounds through ChromeClient.
+    page->chrome().client().updateCompositedSelectionBounds(start, end);
 }
 
 bool FrameView::isRubberBandInProgress() const
 {
     if (scrollbarsSuppressed())
         return false;
 
     // If the main thread updates the scroll position for this FrameView, we should return
     // ScrollAnimator::isRubberBandInProgress().
     if (ScrollAnimator* scrollAnimator = existingScrollAnimator())
@@ skipping 1422 matching lines @@
 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
     if (AXObjectCache* cache = axObjectCache()) {
         cache->remove(scrollbar);
         cache->handleScrollbarUpdate(this);
     }
 }
 
 } // namespace blink