Route selection bounds updates through WebLayerTreeView

Source/core/editing/RenderedPosition.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/editing/RenderedPosition.h"
 
 #include "core/dom/Position.h"
 #include "core/editing/VisiblePosition.h"
+#include "core/rendering/RenderLayer.h"
 
 namespace blink {
 
 static inline RenderObject* rendererFromPosition(const Position& position)
 {
     ASSERT(position.isNotNull());
     Node* rendererNode = 0;
     switch (position.anchorType()) {
     case Position::PositionIsOffsetInAnchor:
         rendererNode = position.computeNodeAfterPosition();
@@ skipping 178 matching lines @@
 
 IntRect RenderedPosition::absoluteRect(LayoutUnit* extraWidthToEndOfLine) const
 {
     if (isNull())
         return IntRect();
 
     IntRect localRect = pixelSnappedIntRect(m_renderer->localCaretRect(m_inlineBox, m_offset, extraWidthToEndOfLine));
     return localRect == IntRect() ? IntRect() : m_renderer->localToAbsoluteQuad(FloatRect(localRect)).enclosingBoundingBox();
 }
 
+void RenderedPosition::layerPoints(GraphicsLayer*& layerBacking, FloatPoint& edgeTop, FloatPoint& edgeBottom) const

[chrishtr, 2014/09/05 22:14:56]

Instead of this method, I suggest you add a method:

LayoutRect RenderedPosition::caretRectInPaintBackingCoordinates() {
    LayoutRect localRect = m_renderer->localCaretRect(m_inlineBox,
m_inlineBox->containerForPaintInvalidation(), m_offset);  // NOTE: this is not
consistent with RenderedPosition::absoluteRect, because it's not pixel-snapped.
Is this wrong?
    RenderLayer::mapRectToPaintInvalidationBacking(m_inlineBox, localRect);
    return localRect;
}

This will require you to make the change to
RenderLayer::mapRectToPaintBackingCoordinates that you sent to me a while back,
along with some adjustments in the compositing code, but that is a good cleanup
anyway. I can assist with that if needed.

[trchen, 2014/09/06 00:06:26]

Actually, getting pixel-snapped bounding box isn't correct for our use. It is
good for paint invalidation, but no good when we need the actual corner points.

+{
+    layerBacking = nullptr;
+    edgeTop = edgeBottom = FloatPoint();
+
+    if (isNull())
+        return;
+
+    LayoutRect rect = m_renderer->localCaretRect(m_inlineBox, m_offset);
+    if (rect == LayoutRect())
+        return;
+
+    const RenderLayerModelObject* paintInvalidationContainer = m_renderer->containerForPaintInvalidation();
+    ASSERT(paintInvalidationContainer);
+    const RenderLayer* layer = paintInvalidationContainer->layer();
+    ASSERT(layer);
+
+    layerBacking = layer->graphicsLayerBacking();
+    if (!layerBacking) // This can happen for RenderFlowThread.
+        return;
+
+    edgeTop = m_renderer->localToContainerPoint(rect.minXMinYCorner(), paintInvalidationContainer, TraverseDocumentBoundaries);
+    edgeBottom = m_renderer->localToContainerPoint(rect.minXMaxYCorner(), paintInvalidationContainer, TraverseDocumentBoundaries);
+
+    RenderLayer::mapPointToPaintBackingCoordinates(paintInvalidationContainer, edgeTop);
+    RenderLayer::mapPointToPaintBackingCoordinates(paintInvalidationContainer, edgeBottom);
+}
+
 bool renderObjectContainsPosition(RenderObject* target, const Position& position)
 {
     for (RenderObject* renderer = rendererFromPosition(position); renderer && renderer->node(); renderer = renderer->parent()) {
         if (renderer == target)
             return true;
     }
     return false;
 }
 
 };