Source/web/tests/data/composited_selection_bounds_transformed.html - Issue 454643002: Route selection bounds updates through WebLayerTreeView

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/composited_selection_bounds_transformed.html

Issue 454643002: Route selection bounds updates through WebLayerTreeView (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revised Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <style>

	2 @font-face {

	3 font-family: ahem;

	4 src: url(Ahem.ttf);

	5 }

	6 * {

	7 font-family: ahem;

	8 }

	9 #text {

	10 transform: rotate(30deg);

	11 }

	12 </style>

	13 <div id="text">The quick brown fox jumped over the lazy dog.</div>

	14 <script>

	15 var range = document.createRange();

	16 var textNode = document.getElementById("text").firstChild;

	17 range.setStart(textNode, 10);

	18 range.setEnd(textNode, 25);

	19 document.getSelection().addRange(range);

	20

	21 window.expectedResult = [document, 157, -87, 151, -77, document, 313, 3, 307 , 13];
	chrishtr 2014/09/18 23:30:55 Did you consider just adding a method to Internals Did you consider just adding a method to Internals and making these regular layout tests? Why is the current approach better? trchen 2014/09/19 00:10:02 Yep I have considered that. Besides adding a funct Show quoted text On 2014/09/18 23:30:55, chrishtr wrote: > Did you consider just adding a method to Internals and making these regular > layout tests? Why is the current approach better? Yep I have considered that. Besides adding a function to query the current selection bounds, we also need a bunch of functions to query internal compositing details, because the layer ID may or may not be consistent between runs. It turns out writing a WebFrameTest needs much fewer lines of code.
	22 </script>

	23

OLD	NEW