Route selection bounds updates through WebLayerTreeView

Source/core/rendering/RenderObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 2431 matching lines @@
 
 FloatPoint RenderObject::localToContainerPoint(const FloatPoint& localPoint, const RenderLayerModelObject* paintInvalidationContainer, MapCoordinatesFlags mode, bool* wasFixed, const PaintInvalidationState* paintInvalidationState) const
 {
     TransformState transformState(TransformState::ApplyTransformDirection, localPoint);
     mapLocalToContainer(paintInvalidationContainer, transformState, mode | ApplyContainerFlip | UseTransforms, wasFixed, paintInvalidationState);
     transformState.flatten();
 
     return transformState.lastPlanarPoint();
 }
 
+FloatPoint RenderObject::localToInvalidationBackingPoint(const LayoutPoint& localPoint, RenderLayer** backingLayer)

[chrishtr, 2014/09/17 16:41:33]

Why can't this be unified with positionFromPaintInvalidationContainer?

[trchen, 2014/09/17 19:34:16]

They do different things.
positionFromPaintInvalidationContainer maps (0, 0) in local space into container
space.
localToInvalidationBackingPoint maps arbitrary point in local space into backing
layer space.

IMO positionFromPaintInvalidationContainer itself doesn't add much value since
all it can do is a subset of localToContainerPoint.

[chrishtr, 2014/09/18 04:06:00]

Then delete the RenderObject::positionFromPaintInvalidationContainer, and have
all the logic in RenderLayer.

+{
+    const RenderLayerModelObject* paintInvalidationContainer = containerForPaintInvalidation();
+    ASSERT(paintInvalidationContainer);
+    RenderLayer* layer = paintInvalidationContainer->layer();
+    ASSERT(layer);
+
+    if (backingLayer)
+        *backingLayer = layer;
+    FloatPoint containerPoint = localToContainerPoint(localPoint, paintInvalidationContainer, TraverseDocumentBoundaries);
+
+    if (layer->compositingState() == NotComposited) // This can happen for RenderFlowThread.
+        return containerPoint;
+
+    RenderLayer::mapPointToPaintBackingCoordinates(paintInvalidationContainer, containerPoint);
+    return containerPoint;
+}
+
+
 LayoutSize RenderObject::offsetFromContainer(const RenderObject* o, const LayoutPoint& point, bool* offsetDependsOnPoint) const
 {
     ASSERT(o == container());
 
     LayoutSize offset = o->columnOffset(point);
 
     if (o->hasOverflowClip())
         offset -= toRenderBox(o)->scrolledContentOffset();
 
     if (offsetDependsOnPoint)
@@ skipping 1027 matching lines @@
 {
     if (object1) {
         const blink::RenderObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
     }
 }
 
 #endif