Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5293)

Unified Diff: chrome/browser/browsing_data/browsing_data_cookie_helper.h

Issue 454623003: Store in memory cookies in a hash set instead of a list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix total ordering. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_cookie_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_cookie_helper.h
diff --git a/chrome/browser/browsing_data/browsing_data_cookie_helper.h b/chrome/browser/browsing_data/browsing_data_cookie_helper.h
index cefd2b58a33385071c35f01b0d81d752491cfe37..7c100f37c6ea3dc3453032e9b9caf3e1bb918850 100644
--- a/chrome/browser/browsing_data/browsing_data_cookie_helper.h
+++ b/chrome/browser/browsing_data/browsing_data_cookie_helper.h
@@ -11,6 +11,7 @@
#include "base/basictypes.h"
#include "base/callback.h"
#include "base/memory/ref_counted.h"
+#include "chrome/browser/browsing_data/canonical_cookie_hash.h"
#include "net/cookies/cookie_monster.h"
class GURL;
@@ -90,7 +91,7 @@ class BrowsingDataCookieHelper
// cookies.
class CannedBrowsingDataCookieHelper : public BrowsingDataCookieHelper {
public:
- typedef std::map<GURL, net::CookieList*> OriginCookieListMap;
+ typedef std::map<GURL, canonical_cookie::CookieHashSet*> OriginCookieSetMap;
explicit CannedBrowsingDataCookieHelper(
net::URLRequestContextGetter* request_context);
@@ -138,28 +139,28 @@ class CannedBrowsingDataCookieHelper : public BrowsingDataCookieHelper {
size_t GetCookieCount() const;
// Returns the map that contains the cookie lists for all frame urls.
- const OriginCookieListMap& origin_cookie_list_map() {
- return origin_cookie_list_map_;
+ const OriginCookieSetMap& origin_cookie_set_map() {
+ return origin_cookie_set_map_;
}
private:
- // Check if the cookie list contains a cookie with the same name,
+ // Check if the cookie set contains a cookie with the same name,
// domain, and path as the newly created cookie. Delete the old cookie
// if does.
bool DeleteMatchingCookie(const net::CanonicalCookie& add_cookie,
- net::CookieList* cookie_list);
+ canonical_cookie::CookieHashSet* cookie_set);
virtual ~CannedBrowsingDataCookieHelper();
- // Returns the |CookieList| for the given |origin|.
- net::CookieList* GetCookiesFor(const GURL& origin);
+ // Returns the |CookieSet| for the given |origin|.
+ canonical_cookie::CookieHashSet* GetCookiesFor(const GURL& origin);
- // Adds the |cookie| to the cookie list for the given |frame_url|.
+ // Adds the |cookie| to the cookie set for the given |frame_url|.
void AddCookie(const GURL& frame_url,
const net::CanonicalCookie& cookie);
- // Map that contains the cookie lists for all frame origins.
- OriginCookieListMap origin_cookie_list_map_;
+ // Map that contains the cookie sets for all frame origins.
+ OriginCookieSetMap origin_cookie_set_map_;
DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataCookieHelper);
};
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_cookie_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698