Issue 454623002: Send privet auth token in PrivetV3 mode instead of X-Privet token

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454623002: Send privet auth token in PrivetV3 mode instead of X-Privet token (Closed)

Created:
6 years, 4 months ago by Noam Samuel

Modified:
6 years, 4 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Send privet auth token in PrivetV3 mode instead of X-Privet token The URLFetcher will send an X-Privet-Auth token, which it gets from the delegate, for PrivetV3. It will not send an X-Privet-Token. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289614

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -9 lines)			Patch
M	chrome/browser/local_discovery/privet_http.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_url_fetcher.h	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_url_fetcher.cc	View	6 chunks	+30 lines, -7 lines	0 comments	Download
M	chrome/browser/local_discovery/privet_url_fetcher_unittest.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 4 months ago (2014-08-13 23:02:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/454623002/1

6 years, 4 months ago (2014-08-13 23:04:31 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-14 11:24:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 289614

Expand Messages | Collapse Messages