Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 454613003: [Mac, Win] Use the correct incognito icon in the new avatar bubble. (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
Reviewers:
msw, oshima, groby-ooo-7-16
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac, Win] Use the correct incognito icon in the new avatar bubble. BUG=399696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289473

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noms (inactive)
Going for a nit-free CL over here :) Please take a look. Thanks!
6 years, 4 months ago (2014-08-12 22:08:23 UTC) #1
noms (inactive)
+ oshima for a/app/theme (msw: c/b/ui/views, groby: c/b/ui/cocoa)
6 years, 4 months ago (2014-08-12 22:09:53 UTC) #2
groby-ooo-7-16
A winnar is you - no nits, LGTM :)
6 years, 4 months ago (2014-08-12 22:10:07 UTC) #3
msw
lgtm without nits.
6 years, 4 months ago (2014-08-12 22:24:53 UTC) #4
noms (inactive)
oshima: ping!
6 years, 4 months ago (2014-08-13 13:29:16 UTC) #5
oshima
lgtm
6 years, 4 months ago (2014-08-13 21:22:33 UTC) #6
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-13 21:24:38 UTC) #7
noms (inactive)
Nailed it. Thanks everyone :)
6 years, 4 months ago (2014-08-13 21:25:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/454613003/20001
6 years, 4 months ago (2014-08-13 21:27:03 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 06:14:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (20001) as 289473

Powered by Google App Engine
This is Rietveld 408576698