Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4432)

Unified Diff: chrome/browser/resources/sync_internals/events.js

Issue 454573002: [Sync] Make about:sync events page more selection friendly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browser_test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/sync_internals/events.js
diff --git a/chrome/browser/resources/sync_internals/events.js b/chrome/browser/resources/sync_internals/events.js
index 25b9ba48c73138d1b9e94d888756691605b75812..f18477d17b55ea9ae4b32e5b121768ea19f5074a 100644
--- a/chrome/browser/resources/sync_internals/events.js
+++ b/chrome/browser/resources/sync_internals/events.js
@@ -2,33 +2,50 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-(function() {
-'use strict';
-var toggleDisplay = function(event) {
- var originatingButton = event.target;
- var detailsNode = originatingButton.parentNode.getElementsByClassName(
- 'details')[0];
+cr.define('chrome.sync.events_tab', function() {
+ 'use strict';
- if (detailsNode.getAttribute('hidden') != null) {
- detailsNode.removeAttribute('hidden');
- } else {
- detailsNode.setAttribute('hidden', 'hidden');
- }
-}
+ function toggleDisplay(event) {
+ var originatingButton = event.target;
+ if (originatingButton.className != 'toggle-button') {
+ return;
+ }
+ var detailsNode = originatingButton.parentNode.getElementsByClassName(
+ 'details')[0];
+ var detailsColumn = detailsNode.parentNode;
+ var detailsRow = detailsColumn.parentNode;
-var syncEvents = $('sync-events');
+ if (!detailsRow.classList.contains('expanded')) {
+ detailsRow.classList.toggle('expanded');
+ detailsColumn.setAttribute('colspan', 4);
+ detailsNode.removeAttribute('hidden');
+ } else {
+ detailsNode.setAttribute('hidden', '');
+ detailsColumn.removeAttribute('colspan');
+ detailsRow.classList.toggle('expanded');
+ }
+ };
-var entries = chrome.sync.log.entries;
-var displaySyncEvents = function() {
- var eventTemplateContext = {
- eventList: entries,
+ function displaySyncEvents() {
+ var entries = chrome.sync.log.entries;
+ var eventTemplateContext = {
+ eventList: entries,
+ };
+ var context = new JsEvalContext(eventTemplateContext);
+ jstProcess(context, $('sync-events'));
};
- var context = new JsEvalContext(eventTemplateContext);
- jstProcess(context, syncEvents);
-}
-syncEvents.addEventListener('click', toggleDisplay);
-chrome.sync.log.addEventListener('append', function(event) {
- displaySyncEvents();
+ function onLoad() {
+ $('sync-events').addEventListener('click', toggleDisplay);
+ chrome.sync.log.addEventListener('append', function(event) {
+ displaySyncEvents();
+ });
+ }
+
+ return {
+ onLoad: onLoad
+ };
});
-})();
+
+document.addEventListener(
+ 'DOMContentLoaded', chrome.sync.events_tab.onLoad, false);
« no previous file with comments | « chrome/browser/resources/sync_internals/events.html ('k') | chrome/browser/resources/sync_internals/index.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698