This CL is a follow up to https://codereview.chromium.org/353713005.

net/socket/ssl_client_socket_pool_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_proxy_client_socket_pool.h"
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
@@ skipping 313 matching lines @@
 TEST_P(SSLClientSocketPoolTest, SocketsConnectWithoutFlag) {
   StaticSocketDataProvider data1;
   StaticSocketDataProvider data2;
   StaticSocketDataProvider data3;
   socket_factory_.AddSocketDataProvider(&data1);
   socket_factory_.AddSocketDataProvider(&data2);
   socket_factory_.AddSocketDataProvider(&data3);
 
   SSLSocketDataProvider ssl(ASYNC, OK);
   ssl.is_in_session_cache = false;
-  ssl.should_block_on_connect = true;
+  ssl.should_pause_on_connect = true;
   SSLSocketDataProvider ssl2(ASYNC, OK);
   ssl2.is_in_session_cache = false;
-  ssl2.should_block_on_connect = true;
+  ssl2.should_pause_on_connect = true;
   SSLSocketDataProvider ssl3(ASYNC, OK);
   ssl3.is_in_session_cache = false;
-  ssl3.should_block_on_connect = true;
+  ssl3.should_pause_on_connect = true;
   socket_factory_.AddSSLSocketDataProvider(&ssl);
   socket_factory_.AddSSLSocketDataProvider(&ssl2);
   socket_factory_.AddSSLSocketDataProvider(&ssl3);
 
   CreatePool(true, false, false);
 
   scoped_refptr<SSLSocketParams> params1 =
       SSLParams(ProxyServer::SCHEME_DIRECT, false);
   scoped_refptr<SSLSocketParams> params2 =
       SSLParams(ProxyServer::SCHEME_DIRECT, false);
@@ skipping 46 matching lines @@
 TEST_P(SSLClientSocketPoolTest, DeletedSSLConnectJob) {
   StaticSocketDataProvider data1;
   StaticSocketDataProvider data2;
   StaticSocketDataProvider data3;
   socket_factory_.AddSocketDataProvider(&data1);
   socket_factory_.AddSocketDataProvider(&data2);
   socket_factory_.AddSocketDataProvider(&data3);
 
   SSLSocketDataProvider ssl(ASYNC, OK);
   ssl.is_in_session_cache = false;
-  ssl.should_block_on_connect = true;
+  ssl.should_pause_on_connect = true;
   SSLSocketDataProvider ssl2(ASYNC, OK);
   ssl2.is_in_session_cache = false;
   SSLSocketDataProvider ssl3(ASYNC, OK);
   ssl3.is_in_session_cache = false;
   socket_factory_.AddSSLSocketDataProvider(&ssl);
   socket_factory_.AddSSLSocketDataProvider(&ssl2);
   socket_factory_.AddSSLSocketDataProvider(&ssl3);
 
   enable_ssl_connect_job_waiting_ = true;
   CreatePool(true, false, false);
@@ skipping 44 matching lines @@
   StaticSocketDataProvider data2;
   StaticSocketDataProvider data3;
   StaticSocketDataProvider data4;
   socket_factory_.AddSocketDataProvider(&data1);
   socket_factory_.AddSocketDataProvider(&data2);
   socket_factory_.AddSocketDataProvider(&data3);
   socket_factory_.AddSocketDataProvider(&data4);
 
   SSLSocketDataProvider ssl(ASYNC, ERR_SSL_PROTOCOL_ERROR);
   ssl.is_in_session_cache = false;
-  ssl.should_block_on_connect = true;
+  ssl.should_pause_on_connect = true;
   SSLSocketDataProvider ssl2(ASYNC, OK);
   ssl2.is_in_session_cache = false;
   SSLSocketDataProvider ssl3(ASYNC, OK);
   ssl3.is_in_session_cache = false;
   SSLSocketDataProvider ssl4(ASYNC, OK);
   ssl4.is_in_session_cache = false;
   socket_factory_.AddSSLSocketDataProvider(&ssl);
   socket_factory_.AddSSLSocketDataProvider(&ssl2);
   socket_factory_.AddSSLSocketDataProvider(&ssl3);
   socket_factory_.AddSSLSocketDataProvider(&ssl4);
@@ skipping 52 matching lines @@
   StaticSocketDataProvider data3;
   StaticSocketDataProvider data4;
   StaticSocketDataProvider data5;
   socket_factory_.AddSocketDataProvider(&data1);
   socket_factory_.AddSocketDataProvider(&data2);
   socket_factory_.AddSocketDataProvider(&data3);
   socket_factory_.AddSocketDataProvider(&data4);
   socket_factory_.AddSocketDataProvider(&data5);
   SSLSocketDataProvider ssl(ASYNC, ERR_SSL_PROTOCOL_ERROR);
   ssl.is_in_session_cache = false;
-  ssl.should_block_on_connect = true;
+  ssl.should_pause_on_connect = true;
   SSLSocketDataProvider ssl2(ASYNC, OK);
   ssl2.is_in_session_cache = false;
-  ssl2.should_block_on_connect = true;
+  ssl2.should_pause_on_connect = true;
   SSLSocketDataProvider ssl3(ASYNC, OK);
   ssl3.is_in_session_cache = false;
   SSLSocketDataProvider ssl4(ASYNC, OK);
   ssl4.is_in_session_cache = false;
   SSLSocketDataProvider ssl5(ASYNC, OK);
   ssl5.is_in_session_cache = false;
 
   socket_factory_.AddSSLSocketDataProvider(&ssl);
   socket_factory_.AddSSLSocketDataProvider(&ssl2);
   socket_factory_.AddSSLSocketDataProvider(&ssl3);
@@ skipping 66 matching lines @@
 TEST_P(SSLClientSocketPoolTest, SimultaneousConnectJobsSuccess) {
   StaticSocketDataProvider data1;
   StaticSocketDataProvider data2;
   StaticSocketDataProvider data3;
   socket_factory_.AddSocketDataProvider(&data1);
   socket_factory_.AddSocketDataProvider(&data2);
   socket_factory_.AddSocketDataProvider(&data3);
 
   SSLSocketDataProvider ssl(ASYNC, OK);
   ssl.is_in_session_cache = false;
-  ssl.should_block_on_connect = true;
+  ssl.should_pause_on_connect = true;
   SSLSocketDataProvider ssl2(ASYNC, OK);
   ssl2.is_in_session_cache = false;
   SSLSocketDataProvider ssl3(ASYNC, OK);
   ssl3.is_in_session_cache = false;
   socket_factory_.AddSSLSocketDataProvider(&ssl);
   socket_factory_.AddSSLSocketDataProvider(&ssl2);
   socket_factory_.AddSSLSocketDataProvider(&ssl3);
 
   enable_ssl_connect_job_waiting_ = true;
   CreatePool(true, false, false);
@@ skipping 743 matching lines @@
   ssl.channel_id_sent = true;
   ssl.SetNextProto(GetParam());
   TestIPPoolingDisabled(&ssl);
 }
 
 // It would be nice to also test the timeouts in SSLClientSocketPool.
 
 }  // namespace
 
 }  // namespace net