Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 454513002: This CL is a follow up to https://codereview.chromium.org/353713005. (Closed)

Created:
6 years, 4 months ago by mshelley
Modified:
6 years, 4 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This CL is a follow up to https://codereview.chromium.org/353713005. It removes the transport connect states from MockSSLCLientSocket Connect() and renames some member variables for clarity. R=wtc@chromium.org,rsleevi@chromium.org BUG=398967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288277

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed formatting change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -37 lines) Patch
M net/socket/socket_test_util.h View 3 chunks +2 lines, -6 lines 0 comments Download
M net/socket/socket_test_util.cc View 5 chunks +4 lines, -22 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mshelley
6 years, 4 months ago (2014-08-07 21:32:23 UTC) #1
Ryan Sleevi
Since Wan-Teh provided the nits, I'll let him do the review.
6 years, 4 months ago (2014-08-07 21:37:23 UTC) #2
wtc
Patch set 1 LGTM. Please remove the ssl_client_socket_pool.cc change from the CL. https://codereview.chromium.org/454513002/diff/1/net/socket/ssl_client_socket_pool.cc File net/socket/ssl_client_socket_pool.cc ...
6 years, 4 months ago (2014-08-07 21:52:17 UTC) #3
mshelley
The CQ bit was checked by mshelley@chromium.org
6 years, 4 months ago (2014-08-07 22:11:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mshelley@chromium.org/454513002/20001
6 years, 4 months ago (2014-08-07 23:01:03 UTC) #5
commit-bot: I haz the power
Change committed as 288277
6 years, 4 months ago (2014-08-08 09:30:13 UTC) #6
wtc
6 years, 4 months ago (2014-08-08 12:06:38 UTC) #7
Message was sent while issue was closed.
Patch set 2 LGTM.

Powered by Google App Engine
This is Rietveld 408576698