Adds some CHECKs to MessagePumpMojo

Adds some CHECKs to MessagePumpMojo

The thread watcher appears to be kicking on when we're trying to
remove a handle. Not sure why. This converts some DCHECKs to CHECKs
and fixes handling of the deadline. I suspect none of this will help,
but it's worth a shot.

BUG=399769
TEST=none
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289600

[darin (slow to review), 2014-08-07 21:16:28]

LGTM

[sky, 2014-08-07 21:47:21]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-07 22:20:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-08 03:11:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 03:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 03:33:04]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[sky, 2014-08-08 14:42:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-08 14:43:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-08 18:07:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 18:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 18:31:52]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[sky, 2014-08-08 20:20:12]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-08 20:23:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-08 20:46:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 21:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 21:09:48]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[sky, 2014-08-09 14:27:18]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-09 14:28:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-09 15:37:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-09 16:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-09 16:47:11]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[sky, 2014-08-11 19:34:34]

Not sure why, but my try jobs on android keep failing because of this:
https://codereview.chromium.org/455833005/ . Once I land that I'll try this one
again.

[sky, 2014-08-12 02:27:10]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-12 02:31:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-12 02:55:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-12 03:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-12 03:15:47]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[sky, 2014-08-12 13:14:28]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-12 13:15:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/1

[commit-bot: I haz the power, 2014-08-12 14:20:02]

Change committed as 288949

[adamk, 2014-08-12 20:32:35]

A revert of this CL has been created in
https://codereview.chromium.org/461133002/ by adamk@chromium.org.

The reason for reverting is: Speculative revert, attempting to diagnose timing
out Blink layout tests on Windows..

[adamk, 2014-08-12 21:37:47]

On 2014/08/12 at 20:32:35, adamk wrote:
> A revert of this CL has been created in
https://codereview.chromium.org/461133002/ by adamk@chromium.org.
> 
> The reason for reverting is: Speculative revert, attempting to diagnose timing
out Blink layout tests on Windows..

For the record, this did resolve the issues we were seeing on the Blink
waterfall with much-lengthened test running times on Windows and Mac. It would
be good to understand what parts of Mojo are being used by content_shell; in
particular, I'm interested in why this slowness seemed to be platform-specific.

[sky, 2014-08-13 17:06:33]

I reopenned as this was reverted. Diff between patchsets 2 and 3 to see what
changed. I was treating a delayed_work_time of null as right now, when it should
have been indefinite. This lead to the message pump mojo thread eating tons of
cycles.

Take another look?

https://codereview.chromium.org/454433003/diff/20001/mojo/common/message_pump...
File mojo/common/message_pump_mojo.cc (right):

https://codereview.chromium.org/454433003/diff/20001/mojo/common/message_pump...
mojo/common/message_pump_mojo.cc:120: SignalControlPipe(*run_state_);
This isn't needed as ScheduleDelayedWork is only invoked on the same thread as
Run is invoked on and when we're not in a wait call.

[darin (slow to review), 2014-08-13 21:54:24]

LGTM

[sky, 2014-08-13 21:59:35]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-08-13 22:03:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/454433003/40001

[commit-bot: I haz the power, 2014-08-14 10:15:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 15:48:32]

Committed patchset #3 (40001) as 289600