Chromium Code Reviews

Issue 454423003: Add animatable flag to CSSProperties.in (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
Reviewers:
alancutter (OOO until 2018), adamk, eseidel
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add animatable flag to CSSProperties.in This patch adds the flag 'animatable' to CSSProperties.in, replacing the existing switch statement in CSSAnimations.cpp. Setting the flag indicates that the property can be animated by CSS animations and transitions. The added code will generate a function in CSSPropertyMetadata, which will eventually also support functions like isInheritedProperty and isValidFirstLetterStyleProperty. This means that the individual lines in CSSProperties.in may start getting a bit long, although a centralized specification of our supported CSS properties arguably helps developers add new CSS properties, by reducing the lines they need to add and adding documentation on what changes need to be made. BUG=396992 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180039 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180213

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+216 lines, -237 lines)
M Source/build/scripts/css_properties.py View 2 chunks +2 lines, -0 lines 0 comments
A Source/build/scripts/make_css_property_metadata.py View 1 chunk +26 lines, -0 lines 0 comments
A Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl View 1 chunk +24 lines, -0 lines 0 comments
M Source/core/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments
M Source/core/animation/StringKeyframe.cpp View 2 chunks +2 lines, -1 line 0 comments
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments
M Source/core/animation/css/CSSAnimations.h View 1 chunk +0 lines, -1 line 0 comments
M Source/core/animation/css/CSSAnimations.cpp View 5 chunks +4 lines, -118 lines 0 comments
M Source/core/core.gyp View 1 chunk +3 lines, -0 lines 0 comments
M Source/core/core_generated.gyp View 1 chunk +18 lines, -0 lines 0 comments
M Source/core/css/CSSProperties.in View 11 chunks +114 lines, -106 lines 0 comments
A + Source/core/css/CSSPropertyMetadata.h View 1 chunk +5 lines, -7 lines 0 comments
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments

Messages

Total messages: 9 (0 generated)
Timothy Loh
(depends on https://codereview.chromium.org/415613002/ landing first, although it's already in the cq)
6 years, 4 months ago (2014-08-12 01:53:12 UTC) #1
alancutter (OOO until 2018)
lgtm
6 years, 4 months ago (2014-08-12 03:18:27 UTC) #2
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-12 06:19:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/454423003/20001
6 years, 4 months ago (2014-08-12 06:19:29 UTC) #4
commit-bot: I haz the power
Change committed as 180039
6 years, 4 months ago (2014-08-12 07:24:44 UTC) #5
adamk
Reverted in https://src.chromium.org/viewvc/blink?revision=180090&view=revision for assertion failures in print preview browser_tests
6 years, 4 months ago (2014-08-12 18:17:28 UTC) #6
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-13 23:57:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/454423003/20001
6 years, 4 months ago (2014-08-13 23:58:11 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 23:58:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180213

Powered by Google App Engine