Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 454413002: include <limits> for std::numeric_limits (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
Reviewers:
msw, ckocagil
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

include <limits> for std::numeric_limits CL 435583003 adds usage of std::numeric_limits without including the required header "limits" header. Let's fix that. BUG=398712 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/gfx/render_text_harfbuzz.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mostyn Bramley-Moore
@ckocagil, msw: please take a look at this tiny fixup
6 years, 4 months ago (2014-08-10 20:49:49 UTC) #1
msw
lgtm, thanks!
6 years, 4 months ago (2014-08-11 23:09:34 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-12 05:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/454413002/1
6 years, 4 months ago (2014-08-12 05:50:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 09:04:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 11:19:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5821)
6 years, 4 months ago (2014-08-12 11:19:21 UTC) #7
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-12 11:20:48 UTC) #8
ckocagil
On 2014/08/12 11:20:48, Mostyn Bramley-Moore wrote: > The CQ bit was checked by mailto:mostynb@opera.com lgtm. ...
6 years, 4 months ago (2014-08-12 11:22:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/454413002/1
6 years, 4 months ago (2014-08-12 11:22:51 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:38:58 UTC) #11
Message was sent while issue was closed.
Change committed as 288986

Powered by Google App Engine
This is Rietveld 408576698