Issue 454263002: QUIC - clean up changes to keep in sync with internal source tree.

Issue 454263002: QUIC - clean up changes to keep in sync with internal source tree. (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC - clean up changes to keep in sync with internal source tree. Fixed wtc's comments from https://codereview.chromium.org/420313005/ + Fixed/added comments. + Used session()->is_server() in quic_crypto_stream.cc R=rch@chromium.org, wtc@chromium.org

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : Fixed rch/wtc's comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
M	net/quic/quic_connection.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_connection.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_crypto_stream.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/quic_crypto_stream.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/quic/quic_dispatcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_framer.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	net/quic/quic_protocol.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_received_packet_manager.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

On 2014/08/09 02:52:40, ramant wrote: Hi Ryan and Wan-Teh, PTAL when you have few minutes. ...

6 years, 4 months ago (2014-08-12 19:20:36 UTC) #2

Ryan Hamilton

lgtm https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc File net/quic/crypto/crypto_handshake.cc (right): https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc#newcode26 net/quic/crypto/crypto_handshake.cc:26: I'd be inclined to remove this. We don't ...

6 years, 4 months ago (2014-08-13 16:23:48 UTC) #3

wtc

Patch set 2 LGTM. https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc File net/quic/crypto/crypto_handshake.cc (right): https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc#newcode26 net/quic/crypto/crypto_handshake.cc:26: Yeah, this blank line was ...

6 years, 4 months ago (2014-08-14 01:54:58 UTC) #4

ramant (doing other things)

https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc File net/quic/crypto/crypto_handshake.cc (right): https://codereview.chromium.org/454263002/diff/20001/net/quic/crypto/crypto_handshake.cc#newcode26 net/quic/crypto/crypto_handshake.cc:26: On 2014/08/13 16:23:48, Ryan Hamilton wrote: > I'd be ...

6 years, 4 months ago (2014-08-14 19:58:58 UTC) #5

Patch set 3 LGTM.

Expand Messages | Collapse Messages