Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 454253004: GN: Specify grit generated output paths to be the same as gyp's. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

GN: Specify grit generated output paths to be the same as gyp's. BUG=401588 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/app/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Lei Zhang
chrome/chrome.gyp has |grit_out_dir| that applies to all grit targets in chrome/*.gypi. This CL will make ...
6 years, 4 months ago (2014-08-12 07:13:27 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-12 18:13:06 UTC) #2
Lei Zhang
+jamescook for extensions/BUILD.gn
6 years, 4 months ago (2014-08-12 19:09:03 UTC) #3
James Cook
lgtm
6 years, 4 months ago (2014-08-12 20:14:03 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 20:59:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/454253004/1
6 years, 4 months ago (2014-08-12 21:02:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 22:57:34 UTC) #7
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 22:58:17 UTC) #8
Lei Zhang
Blah, +yoz since he's a real extensions/ OWNER.
6 years, 4 months ago (2014-08-12 22:58:52 UTC) #9
Yoyo Zhou
extensions LGTM
6 years, 4 months ago (2014-08-12 23:24:38 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 23:25:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/454253004/1
6 years, 4 months ago (2014-08-12 23:52:15 UTC) #12
commit-bot: I haz the power
Change committed as 289149
6 years, 4 months ago (2014-08-13 01:39:43 UTC) #13
Timothy Loh
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/461213003/ by timloh@chromium.org. The ...
6 years, 4 months ago (2014-08-13 07:20:16 UTC) #14
zerny-chromium
6 years, 4 months ago (2014-08-13 11:28:59 UTC) #15
Message was sent while issue was closed. 
On 2014/08/13 07:20:16, Timothy Loh wrote:
> A revert of this CL (patchset #1) has been created in
> https://codereview.chromium.org/461213003/ by mailto:timloh@chromium.org.
> 
> The reason for reverting is: Broke GN compile and try jobs
> 
> http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN.

Relanded this in https://codereview.chromium.org/468733003/ together with the
outstanding fix from CL https://codereview.chromium.org/467023003/

Powered by Google App Engine
This is Rietveld 408576698