Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3212)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_request.h

Issue 454253002: Location chooser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Swapping to address InfoBar currying callback case Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_bubble_request.h
diff --git a/chrome/browser/ui/website_settings/permission_bubble_request.h b/chrome/browser/ui/website_settings/permission_bubble_request.h
index 49d71de90570269534d798b4f302a01cd10964a3..6178e39ca7cb63f3fa782c27c2fc569354c7196c 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_request.h
+++ b/chrome/browser/ui/website_settings/permission_bubble_request.h
@@ -18,8 +18,11 @@
// requests, or depending on the situation, not shown at all.
class PermissionBubbleRequest {
public:
+ enum Type { kQuota, kDownload, kGeolocation, kMedia, kOther };
virtual ~PermissionBubbleRequest() {}
+ virtual PermissionBubbleRequest::Type GetType() const = 0;
+
// The icon to use next to the message text fragment in the permission bubble.
// Must be a valid icon of size 16x16. (TODO(gbillock): tbd size)
virtual int GetIconID() const = 0;
@@ -45,6 +48,9 @@ class PermissionBubbleRequest {
// Called when the user has granted the requested permission.
virtual void PermissionGranted() = 0;
+ // Called when the user has granted the requested permission with a choice
+ void PermissionGranted(int choice) { PermissionGranted(); }
+
// Called when the user has denied the requested permission.
virtual void PermissionDenied() = 0;

Powered by Google App Engine
This is Rietveld 408576698