Location chooser

content/public/common/geoposition.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/geoposition.h"
 
 namespace {
 // Sentinel values to mark invalid data. (WebKit carries companion is_valid
 // bools for this purpose; we may eventually follow that approach, but
 // sentinels worked OK in the Gears code this is based on.)
@@ skipping 18 matching lines @@
       error_code(ERROR_CODE_NONE) {
 }
 
 bool Geoposition::Validate() const {
   return latitude >= -90. && latitude <= 90. &&
          longitude >= -180. && longitude <= 180. &&
          accuracy >= 0. &&
          !timestamp.is_null();
 }
 
+Geoposition Geoposition::ApplyPrecision(const int choice) const {

[meacer, 2014/08/15 22:20:25]

In fact, it looks like  Since this method returns a new GeoPosition object,
you'll want to reflect that. 

[mhm, 2014/08/15 23:18:57]

Done.

+  Geoposition newGeoposition = *this;
+  switch (choice) {
+    case 1:
+      // City granuality.
+      newGeoposition.latitude =
+          ((int)(newGeoposition.latitude + 0.5 * 10.0)) / 10.0;
+      newGeoposition.longitude =
+          ((int)(newGeoposition.longitude + 0.5 * 10.0)) / 10.0;
+      break;
+    case 2:
+      // State granuality.
+      newGeoposition.latitude = (int)newGeoposition.latitude;

[meacer, 2014/08/15 22:20:25]

May be better: static_cast<int>(std::floor(newGeoposition.latitute)) (with
#include <cmath>)

[mhm, 2014/08/15 23:18:57]

Done.

+      newGeoposition.longitude = (int)newGeoposition.longitude;
+      break;
+    case 3:
+      // Country granuality.
+      newGeoposition.latitude = (int)(newGeoposition.latitude / 10.0);
+      newGeoposition.longitude = (int)(newGeoposition.longitude / 10.0);

[meacer, 2014/08/15 22:20:25]

You might want to add that this is a POC, and the calculations aren't accurate.
Also, you'll want to put this whole feature behind a flag if you want to land
it.

[mhm, 2014/08/15 23:18:57]

Done.

+      break;
+  }
+  return newGeoposition;
+}
+
 }  // namespace content