Chromium Code Reviews| Index: ui/webui/resources/js/cr/ui/menu.js |
| diff --git a/ui/webui/resources/js/cr/ui/menu.js b/ui/webui/resources/js/cr/ui/menu.js |
| index cb3a7c672d96dc6b7fa3a5b4a23a0ed9e9830d0e..17c9d69237a33401cbf775695ab5f71e112a796e 100644 |
| --- a/ui/webui/resources/js/cr/ui/menu.js |
| +++ b/ui/webui/resources/js/cr/ui/menu.js |
| @@ -88,7 +88,7 @@ cr.define('cr.ui', function() { |
| /** |
| * Walks up the ancestors of |el| until a menu item belonging to this menu |
| * is found. |
| - * @param {Element} el The element to start searching from. |
| + * @param {Node} el The element to start searching from. |
|
Dan Beam
2014/08/19 00:31:53
s/el/node
Vitaly Pavlenko
2014/08/19 18:30:27
Done.
|
| * @return {cr.ui.MenuItem} The found menu item or null. |
| * @private |
| */ |
| @@ -105,7 +105,7 @@ cr.define('cr.ui', function() { |
| * @private |
| */ |
| handleMouseOver_: function(e) { |
| - var overItem = this.findMenuItem_(e.target); |
| + var overItem = this.findMenuItem_(/** @type {Element} */(e.target)); |
| this.selectedItem = overItem; |
| }, |
| @@ -267,7 +267,7 @@ cr.define('cr.ui', function() { |
| /** |
| * The selected menu item. |
| - * @type {number} |
| + * type {number} |
|
Dan Beam
2014/08/19 00:31:53
make a real jsdoc param or remove
Vitaly Pavlenko
2014/08/19 18:30:27
Not done. We still have no type checking for Objec
|
| */ |
| cr.defineProperty(Menu, 'selectedIndex', cr.PropertyKind.JS, |
| selectedIndexChanged); |