Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 454223004: Typecheck JS files for chrome://history (Closed)

Created:
6 years, 4 months ago by Vitaly Pavlenko
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@B_download
Project:
chromium
Visibility:
Public.

Description

Typecheck JS files for chrome://history BUG=393873 R=dbeam@chromium.org TEST=./third_party/closure_compiler/runner/build_runner_jar.py && gyp --depth . chrome/browser/resources/history/compiled_resources.gyp && ninja -C out/Default Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291243

Patch Set 1 #

Patch Set 2 : wrong rebase, will fix it #

Patch Set 3 : right rebase, switched to gyp #

Total comments: 32

Patch Set 4 : fixed issues #

Total comments: 1

Patch Set 5 : fix a nit, add local alias to enums #

Patch Set 6 : rebase (hope it will work) #

Patch Set 7 : rebase done right #

Patch Set 8 : rebase once again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -225 lines) Patch
A chrome/browser/resources/history/compiled_resources.gyp View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/history/history.js View 1 2 3 4 27 chunks +94 lines, -47 lines 0 comments Download
M chrome/browser/resources/history/history_focus_manager.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/alert_overlay.js View 1 2 3 4 3 chunks +11 lines, -10 lines 0 comments Download
M ui/webui/resources/js/cr/ui/command.js View 1 2 3 3 chunks +4 lines, -10 lines 0 comments Download
M ui/webui/resources/js/cr/ui/focus_row.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/js/cr/ui/menu.js View 1 2 3 4 5 6 7 3 chunks +8 lines, -8 lines 0 comments Download
M ui/webui/resources/js/cr/ui/menu_button.js View 1 2 3 4 5 chunks +34 lines, -26 lines 0 comments Download
M ui/webui/resources/js/cr/ui/menu_item.js View 1 4 chunks +5 lines, -8 lines 0 comments Download
M ui/webui/resources/js/cr/ui/position_util.js View 1 2 3 4 5 chunks +44 lines, -41 lines 0 comments Download
M ui/webui/resources/js/event_tracker.js View 1 2 3 1 chunk +60 lines, -69 lines 0 comments Download
M ui/webui/resources/js/util.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Vitaly Pavlenko
6 years, 4 months ago (2014-08-09 01:09:55 UTC) #1
Vitaly Pavlenko
Dan, please, review this CL.
6 years, 4 months ago (2014-08-18 22:46:42 UTC) #2
Dan Beam
https://codereview.chromium.org/454223004/diff/40001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/454223004/diff/40001/chrome/browser/resources/history/history.js#newcode51 chrome/browser/resources/history/history.js:51: * @typedef {{allTimestamps: Array.<Number>, Number -> number https://codereview.chromium.org/454223004/diff/40001/chrome/browser/resources/history/history.js#newcode66 chrome/browser/resources/history/history.js:66: ...
6 years, 4 months ago (2014-08-19 00:31:54 UTC) #3
Vitaly Pavlenko
https://codereview.chromium.org/454223004/diff/40001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/454223004/diff/40001/chrome/browser/resources/history/history.js#newcode51 chrome/browser/resources/history/history.js:51: * @typedef {{allTimestamps: Array.<Number>, On 2014/08/19 00:31:53, Dan Beam ...
6 years, 4 months ago (2014-08-19 18:30:28 UTC) #4
Dan Beam
lgtm w/nit https://chromiumcodereview.appspot.com/454223004/diff/60001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://chromiumcodereview.appspot.com/454223004/diff/60001/chrome/browser/resources/history/history.js#newcode209 chrome/browser/resources/history/history.js:209: entryBox.addEventListener('click', /** @type {function(Event)} */( i liked ...
6 years, 4 months ago (2014-08-20 03:48:55 UTC) #5
Vitaly Pavlenko
On 2014/08/20 03:48:55, Dan Beam wrote: > lgtm w/nit > > https://chromiumcodereview.appspot.com/454223004/diff/60001/chrome/browser/resources/history/history.js > File chrome/browser/resources/history/history.js ...
6 years, 4 months ago (2014-08-20 22:23:59 UTC) #6
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-20 22:24:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/454223004/80001
6 years, 4 months ago (2014-08-20 22:24:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 00:12:46 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 00:16:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55325) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8079)
6 years, 4 months ago (2014-08-21 00:16:27 UTC) #11
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-21 01:17:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/454223004/80001
6 years, 4 months ago (2014-08-21 01:19:17 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 01:23:08 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:25:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55420)
6 years, 4 months ago (2014-08-21 01:25:56 UTC) #16
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-21 15:11:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/454223004/80001
6 years, 4 months ago (2014-08-21 15:13:13 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 20:07:19 UTC) #19
Vitaly Pavlenko
The CQ bit was unchecked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-21 20:08:09 UTC) #20
Vitaly Pavlenko
The CQ bit was checked by vitalyp@chromium.org
6 years, 4 months ago (2014-08-21 20:35:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/454223004/140001
6 years, 4 months ago (2014-08-21 20:37:51 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 23:03:01 UTC) #23
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:36:06 UTC) #24
Message was sent while issue was closed. 
Committed patchset #8 (140001) as 291243

Powered by Google App Engine
This is Rietveld 408576698