Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 454223003: Remove the concept of 'integration tests' from test-webkitpy. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove the concept of 'integration tests' from test-webkitpy. There's not really a useful difference between unittests and integration tests in webkitpy these days, so this removes the integrationtest concept and renames the files for consistency w/ everything else. This is being done in preparation for replacing test-webkitpy with the generic python test runner (by removing nonstandard things from test-webkitpy). This also removes the custom TestLoader I wrote since we don't need it any more. R=eseidel@chromium.org BUG=402172 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180235

Patch Set 1 #

Patch Set 2 : merge forward, remove dead / uneeded code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -1691 lines) Patch
M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py View 1 chunk +0 lines, -1062 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py View 1 chunk +0 lines, -583 lines 0 comments Download
M Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 2 chunks +545 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/test/main.py View 1 4 chunks +7 lines, -27 lines 0 comments Download
M Tools/Scripts/webkitpy/test/main_unittest.py View 1 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-08-08 23:07:32 UTC) #1
Dirk Pranke
ping?
6 years, 4 months ago (2014-08-12 20:53:45 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-13 22:00:03 UTC) #3
eseidel
lgtm
6 years, 4 months ago (2014-08-13 22:00:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/454223003/1
6 years, 4 months ago (2014-08-13 22:00:40 UTC) #5
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-14 00:49:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/454223003/20001
6 years, 4 months ago (2014-08-14 00:50:39 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 05:09:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180235

Powered by Google App Engine
This is Rietveld 408576698