ui/views/bubble/bubble_border.cc - Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 454173002: Fixed BubbleBorder sizing problems & added unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/bubble/bubble_border.cc

diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc

index 03b422aefb285f83b7d39f88271f1ebbab087b19..bf1aa1aebe5a6e228b752ca227a31425aa9019ba 100644

--- a/ui/views/bubble/bubble_border.cc

+++ b/ui/views/bubble/bubble_border.cc

@@ -278,7 +278,7 @@ gfx::Size BubbleBorder::GetSizeForContentsSize(

std::max(images_->arrow_thickness + images_->border_interior_thickness,

images_->border_thickness);

// Only take arrow image sizes into account when the bubble tip is shown.

- if (arrow_paint_type_ == PAINT_TRANSPARENT || !has_arrow(arrow_))

+ if (arrow_paint_type_ == PAINT_NONE || !has_arrow(arrow_))

msw 2014/08/11 22:26:32 Wow, nice catch!

size.SetToMax(gfx::Size(min, min));

else if (is_arrow_on_horizontal(arrow_))

size.SetToMax(gfx::Size(min_with_arrow_width, min_with_arrow_thickness));

« no previous file with comments | « no previous file | ui/views/bubble/bubble_border_unittest.cc » ('j') | ui/views/bubble/bubble_border_unittest.cc » ('J')