Issue 454133004: Use common converter for -webkit-column-[gap, width].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 454133004: Use common converter for -webkit-column-[gap, width]. (Closed)

Created:
6 years, 4 months ago by andersr

Modified:
6 years, 4 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use common converter for -webkit-column-[gap, width]. This patch adds support for the 'converter' attribute for a group of semi-custom CSS properties handled by the 'apply_auto' macro. This gets rid of the redundant 'compute_length=true/false' argument, plus the code related to that. It also makes it easier to add other things to the apply_auto-list which can't be converted with computeLength or a primitive value mapping. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180437

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl	View		4 chunks	+12 lines, -13 lines	0 comments	Download
	M	Source/core/css/CSSProperties.in	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/454133004/1

6 years, 4 months ago (2014-08-18 08:35:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180437

Expand Messages | Collapse Messages