Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4548)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 454133003: [ChromeDriver] Implementing tracing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing import ordering Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/logging_unittest.cc » ('j') | chrome/test/chromedriver/performance_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging.cc
diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc
index be1d5c3d7bcee855733f66dde4538820966017e4..6ac50fab926d2c280e84f86f12db3ec665a4b578 100644
--- a/chrome/test/chromedriver/logging.cc
+++ b/chrome/test/chromedriver/logging.cc
@@ -239,6 +239,7 @@ bool InitLogging() {
}
Status CreateLogs(const Capabilities& capabilities,
+ const Session* session,
ScopedVector<WebDriverLog>* out_logs,
ScopedVector<DevToolsEventListener>* out_devtools_listeners,
ScopedVector<CommandListener>* out_command_listeners) {
@@ -258,7 +259,8 @@ Status CreateLogs(const Capabilities& capabilities,
WebDriverLog* log = new WebDriverLog(type, Log::kAll);
logs.push_back(log);
PerformanceLogger* perf_log =
- new PerformanceLogger(log, capabilities.perf_logging_prefs);
+ new PerformanceLogger(log, session,
+ capabilities.perf_logging_prefs);
// We use a proxy for |perf_log|'s |CommandListener| interface.
// Otherwise, |perf_log| would be owned by both session->chrome and
// |session|, which would lead to memory errors on destruction.
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/logging_unittest.cc » ('j') | chrome/test/chromedriver/performance_logger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698