Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 454133003: [ChromeDriver] Implementing tracing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/capabilities.h ('k') | chrome/test/chromedriver/capabilities_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index 474d3dbb88f5fa61e6a38bceb19eaefc7017c543..19ccd76bd7a59364b111630e8eec1c4a9925956b 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -47,6 +47,18 @@ Status ParseString(std::string* to_set,
return Status(kOk);
}
+Status ParseInterval(int* to_set,
+ const base::Value& option,
+ Capabilities* capabilities) {
+ int parsed_int = 0;
+ if (!option.GetAsInteger(&parsed_int))
+ return Status(kUnknownError, "must be an integer");
+ if (parsed_int <= 0)
+ return Status(kUnknownError, "must be positive");
+ *to_set = parsed_int;
+ return Status(kOk);
+}
+
Status ParseFilePath(base::FilePath* to_set,
const base::Value& option,
Capabilities* capabilities) {
@@ -323,6 +335,8 @@ Status ParsePerfLoggingPrefs(const base::Value& option,
return Status(kUnknownError, "must be a dictionary");
std::map<std::string, Parser> parser_map;
+ parser_map["bufferUsageReportingInterval"] = base::Bind(&ParseInterval,
+ &capabilities->perf_logging_prefs.buffer_usage_reporting_interval);
parser_map["enableNetwork"] = base::Bind(
&ParseInspectorDomainStatus, &capabilities->perf_logging_prefs.network);
parser_map["enablePage"] = base::Bind(
@@ -522,7 +536,8 @@ PerfLoggingPrefs::PerfLoggingPrefs()
: network(InspectorDomainStatus::kDefaultEnabled),
page(InspectorDomainStatus::kDefaultEnabled),
timeline(InspectorDomainStatus::kDefaultEnabled),
- trace_categories() {}
+ trace_categories(),
+ buffer_usage_reporting_interval(1000) {}
PerfLoggingPrefs::~PerfLoggingPrefs() {}
« no previous file with comments | « chrome/test/chromedriver/capabilities.h ('k') | chrome/test/chromedriver/capabilities_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698