[ChromeDriver] Implementing tracing support

chrome/test/chromedriver/performance_logger_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/performance_logger.h"
 
 #include "base/compiler_specific.h"
 #include "base/format_macros.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/test/chromedriver/chrome/log.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 #include "chrome/test/chromedriver/chrome/stub_devtools_client.h"
+#include "chrome/test/chromedriver/session.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 class FakeDevToolsClient : public StubDevToolsClient {
  public:
   explicit FakeDevToolsClient(const std::string& id)
       : id_(id), listener_(NULL) {}
   virtual ~FakeDevToolsClient() {}
 
@@ skipping 116 matching lines @@
   EXPECT_EQ("Page.enable", client.PopSentCommand());
   EXPECT_EQ("Timeline.start", client.PopSentCommand());
   EXPECT_TRUE(client.PopSentCommand().empty());
 }
 
 }  // namespace
 
 TEST(PerformanceLogger, OneWebView) {
   FakeDevToolsClient client("webview-1");
   FakeLog log;
-  PerformanceLogger logger(&log);
+  Session session("test");
+  PerformanceLogger logger(&log, &session);
 
   client.AddListener(&logger);
   logger.OnConnected(&client);
   ExpectEnableDomains(client);
   ASSERT_EQ(kOk, client.TriggerEvent("Network.gaga").code());
   ASSERT_EQ(kOk, client.TriggerEvent("Page.ulala").code());
   // Ignore -- different domain.
   ASSERT_EQ(kOk, client.TriggerEvent("Console.bad").code());
 
   ASSERT_EQ(2u, log.GetEntries().size());
   ValidateLogEntry(log.GetEntries()[0], "webview-1", "Network.gaga");
   ValidateLogEntry(log.GetEntries()[1], "webview-1", "Page.ulala");
 }
 
 TEST(PerformanceLogger, TwoWebViews) {
   FakeDevToolsClient client1("webview-1");
   FakeDevToolsClient client2("webview-2");
   FakeLog log;
-  PerformanceLogger logger(&log);
+  Session session("test");
+  PerformanceLogger logger(&log, &session);
 
   client1.AddListener(&logger);
   client2.AddListener(&logger);
   logger.OnConnected(&client1);
   logger.OnConnected(&client2);
   ExpectEnableDomains(client1);
   ExpectEnableDomains(client2);
   // OnConnected sends the enable command only to that client, not others.
   client1.ConnectIfNecessary();
   ExpectEnableDomains(client1);
   EXPECT_TRUE(client2.PopSentCommand().empty());
 
   ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code());
   ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code());
 
   ASSERT_EQ(2u, log.GetEntries().size());
   ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");
   ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");
 }
 
 TEST(PerformanceLogger, PerfLoggingPrefs) {
   FakeDevToolsClient client("webview-1");
   FakeLog log;
+  Session session("test");
   PerfLoggingPrefs prefs;
   ASSERT_EQ(PerfLoggingPrefs::InspectorDomainStatus::kDefaultEnabled,
             prefs.network);
   prefs.network = PerfLoggingPrefs::InspectorDomainStatus::kExplicitlyDisabled;
-  // Trace categories should be ignored until tracing support is implemented.
   prefs.trace_categories = "benchmark,webkit.console";
-  PerformanceLogger logger(&log, prefs);
+  PerformanceLogger logger(&log, &session, prefs);
 
   client.AddListener(&logger);
   logger.OnConnected(&client);
   EXPECT_EQ("Page.enable", client.PopSentCommand());
-  // Trace categories ignored, so Timeline shouldn't be implicitly disabled.
-  EXPECT_EQ("Timeline.start", client.PopSentCommand());
+  // No Timeline.enable command since specifying trace categories implicitly
+  // disables Timeline feed.
   EXPECT_TRUE(client.PopSentCommand().empty());
 }