Refactor getExcludedIntervals since only one LineSegment is ever returned

Refactor getExcludedIntervals since only one LineSegment is ever returned

The interface for getExcludedIntervals was designed when shape-inside
was still a thing, and it was possible for a line in a shape to have
multiple segments. shape-outside can only have one segment per line, so
this refactors the code to simplify and reflect that reality.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179876

[rwlbuis, 2014-08-08 20:38:41]

lgtm

[leviw_travelin_and_unemployed, 2014-08-08 21:46:59]

lgtm.

https://codereview.chromium.org/454123002/diff/1/Source/core/rendering/shapes...
File Source/core/rendering/shapes/Shape.h (right):

https://codereview.chromium.org/454123002/diff/1/Source/core/rendering/shapes...
Source/core/rendering/shapes/Shape.h:61: bool isValid;
This makes me wish this were a class instead of a struct.

[Bem Jones-Bey (adobe), 2014-08-08 22:21:03]

On 2014/08/08 21:46:59, leviw wrote:
> lgtm.
> 
>
https://codereview.chromium.org/454123002/diff/1/Source/core/rendering/shapes...
> File Source/core/rendering/shapes/Shape.h (right):
> 
>
https://codereview.chromium.org/454123002/diff/1/Source/core/rendering/shapes...
> Source/core/rendering/shapes/Shape.h:61: bool isValid;
> This makes me wish this were a class instead of a struct.

Yeah, I had the same thought, but I also think the name is terrine now since a
LineSegment isn't really a thing anymore, and ShapeInterval is already taken.
When I come up with a better name for it, I'll change it to a class.

[Bem Jones-Bey (adobe), 2014-08-08 22:21:08]

The CQ bit was checked by bjonesbe@adobe.com

[commit-bot: I haz the power, 2014-08-08 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/454123002/1

[commit-bot: I haz the power, 2014-08-08 23:11:48]

Change committed as 179876