Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 454083003: Enable skipping tests that aren't impacted by change on windows (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
jabdelmalek, jam
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Enable skipping tests that aren't impacted by change on windows linux_chromium_rel_swarming seems find, so I'm trying on windows next. BUG=109173 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288425

Patch Set 1 #

Patch Set 2 : add x64 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M testing/buildbot/chromium_trybot.json View 1 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
sky
TBRing since trivial enable.
6 years, 4 months ago (2014-08-08 19:35:23 UTC) #1
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-08 19:35:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/454083003/20001
6 years, 4 months ago (2014-08-08 19:38:51 UTC) #3
sky
Committed patchset #2 manually as 288425 (presubmit successful).
6 years, 4 months ago (2014-08-08 20:53:59 UTC) #4
jabdelmalek
https://codereview.chromium.org/454083003/diff/20001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/454083003/diff/20001/testing/buildbot/chromium_trybot.json#newcode219 testing/buildbot/chromium_trybot.json:219: "win_chromium_rel", nit: please also add win_chromium_rel_swarming
6 years, 4 months ago (2014-08-08 21:01:07 UTC) #5
sky
6 years, 4 months ago (2014-08-08 21:56:31 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/454083003/diff/20001/testing/buildbot/chromiu...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/454083003/diff/20001/testing/buildbot/chromiu...
testing/buildbot/chromium_trybot.json:219: "win_chromium_rel",
On 2014/08/08 21:01:07, jabdelmalek wrote:
> nit: please also add win_chromium_rel_swarming

I'm going to stick with these two for now. Next week I'll turn this on for all
bots.

Powered by Google App Engine
This is Rietveld 408576698