Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/password_manager/password_store_mac_internal.h

Issue 454083002: Fix a memory leak in PasswordStoreMac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changed to bool Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac_internal.h
diff --git a/chrome/browser/password_manager/password_store_mac_internal.h b/chrome/browser/password_manager/password_store_mac_internal.h
index 21fe031c1f5dc6382c2cf17bb0107ad0a184810e..8bd1328df5f9bade15a0b22fea9104694e7d11de 100644
--- a/chrome/browser/password_manager/password_store_mac_internal.h
+++ b/chrome/browser/password_manager/password_store_mac_internal.h
@@ -30,12 +30,9 @@ class MacKeychainPasswordFormAdapter {
const std::string& signon_realm,
autofill::PasswordForm::Scheme scheme);
- // Returns the PasswordForm for the Keychain entry that matches |form| on all
- // of the fields that uniquely identify a Keychain item, or NULL if there is
- // no such entry.
- // Caller is responsible for deleting the returned form.
- autofill::PasswordForm* PasswordExactlyMatchingForm(
- const autofill::PasswordForm& query_form);
+ // Returns true if there is the Keychain entry that matches |query_form| on
+ // all of the fields that uniquely identify a Keychain item.
+ bool PasswordExactlyMatchingForm(const autofill::PasswordForm& query_form);
Ilya Sherman 2014/08/13 17:18:10 nit: Perhaps rename this to "HasPasswordExactlyMat
vasilii 2014/08/14 08:06:33 Done.
// Returns true if the keychain contains any items that are mergeable with
// |query_form|. This is different from actually extracting the passwords
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698