Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 454063004: Adds remote devtools support to cast_shell. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, byungchul, damienv1
CC:
chromium-reviews, ozone-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds remote devtools support to cast_shell. This is based largely on ShellDevtoolsDelegate, but is enabled/disabled conditionally based on a preference value that can be controlled by the cast receiver. R=damienv@chromium.org,lcwu@chromium.org,byungchul@chromium.org BUG=400919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289812

Patch Set 1 #

Total comments: 8

Patch Set 2 : review comments #

Patch Set 3 : make sure to teardown dev_tools_ in PostMainMessageLoopRun #

Total comments: 2

Patch Set 4 : byungchul comment #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -15 lines) Patch
M chromecast/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 2 3 4 6 chunks +25 lines, -1 line 0 comments Download
M chromecast/common/chromecast_config.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + chromecast/common/pref_names.h View 1 chunk +5 lines, -3 lines 0 comments Download
A chromecast/common/pref_names.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.h View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
A chromecast/shell/browser/devtools/cast_dev_tools_delegate.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc View 1 1 chunk +150 lines, -0 lines 0 comments Download
A chromecast/shell/browser/devtools/remote_debugging_server.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chromecast/shell/browser/devtools/remote_debugging_server.cc View 1 2 3 1 chunk +116 lines, -0 lines 0 comments Download
A + chromecast/shell/browser/devtools/remote_debugging_server_simple.cc View 1 chunk +5 lines, -2 lines 0 comments Download
A + chromecast/shell/browser/resources/resource_ids View 2 chunks +5 lines, -5 lines 0 comments Download
A + chromecast/shell/browser/resources/shell_devtools_discovery_page.html View 2 chunks +5 lines, -3 lines 0 comments Download
A chromecast/shell/browser/resources/shell_resources.grd View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
gunsch
6 years, 4 months ago (2014-08-08 20:50:59 UTC) #1
lcwu1
https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h File chromecast/shell/browser/devtools/cast_dev_tools_delegate.h (right): https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.h#newcode8 chromecast/shell/browser/devtools/cast_dev_tools_delegate.h:8: #include "base/prefs/pref_member.h" This include doesn't appear to be used.
6 years, 4 months ago (2014-08-14 14:55:54 UTC) #2
damienv1
https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc File chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc (right): https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc#newcode56 chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc:56: base::TimeTicks last_activity_time_; DISALLOW_COPY_AND_ASSIGN missing ? (I didn't check whether ...
6 years, 4 months ago (2014-08-14 15:57:19 UTC) #3
damienv1
https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc File chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc (right): https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc#newcode106 chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc:106: return false; Same question: why is the underlying reason ...
6 years, 4 months ago (2014-08-14 16:00:37 UTC) #4
gunsch
https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc File chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc (right): https://codereview.chromium.org/454063004/diff/1/chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc#newcode56 chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc:56: base::TimeTicks last_activity_time_; On 2014/08/14 15:57:19, damienv1 wrote: > DISALLOW_COPY_AND_ASSIGN ...
6 years, 4 months ago (2014-08-14 16:26:43 UTC) #5
lcwu1
lgtm
6 years, 4 months ago (2014-08-14 18:18:48 UTC) #6
damienv1
lgtm
6 years, 4 months ago (2014-08-14 20:34:08 UTC) #7
byungchul
https://codereview.chromium.org/454063004/diff/40001/chromecast/shell/browser/devtools/remote_debugging_server.cc File chromecast/shell/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/454063004/diff/40001/chromecast/shell/browser/devtools/remote_debugging_server.cc#newcode99 chromecast/shell/browser/devtools/remote_debugging_server.cc:99: devtools_http_handler_->Stop(); please comment that Stop() destroys devtools_http_handler_.
6 years, 4 months ago (2014-08-14 20:43:54 UTC) #8
gunsch
https://codereview.chromium.org/454063004/diff/40001/chromecast/shell/browser/devtools/remote_debugging_server.cc File chromecast/shell/browser/devtools/remote_debugging_server.cc (right): https://codereview.chromium.org/454063004/diff/40001/chromecast/shell/browser/devtools/remote_debugging_server.cc#newcode99 chromecast/shell/browser/devtools/remote_debugging_server.cc:99: devtools_http_handler_->Stop(); On 2014/08/14 20:43:54, byungchul wrote: > please comment ...
6 years, 4 months ago (2014-08-14 21:28:50 UTC) #9
byungchul
lgtm
6 years, 4 months ago (2014-08-14 21:35:53 UTC) #10
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-14 21:37:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/454063004/60001
6 years, 4 months ago (2014-08-14 21:38:53 UTC) #12
gunsch
The CQ bit was unchecked by gunsch@chromium.org
6 years, 4 months ago (2014-08-14 22:02:07 UTC) #13
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-14 22:02:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/454063004/80001
6 years, 4 months ago (2014-08-14 22:04:09 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 04:11:55 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 05:49:32 UTC) #17
Message was sent while issue was closed. 
Committed patchset #5 (80001) as 289812

Powered by Google App Engine
This is Rietveld 408576698