Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 454053004: Added comments in the WindowEventDispatcher::OnOtherRootGotCapture function. (Closed)

Created:
6 years, 4 months ago by ananta
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

Added comments in the WindowEventDispatcher::OnOtherRootGotCapture function. This is to clarify why we should not be dispatching synthetic mouse exit events on Windows. BUG=394672 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288970

Patch Set 1 #

Patch Set 2 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/aura/window_event_dispatcher.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ananta
6 years, 4 months ago (2014-08-11 23:13:31 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-11 23:54:43 UTC) #2
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 4 months ago (2014-08-12 01:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/454053004/20001
6 years, 4 months ago (2014-08-12 01:33:54 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:09:49 UTC) #5
Message was sent while issue was closed.
Change committed as 288970

Powered by Google App Engine
This is Rietveld 408576698