Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 454013002: unbundle: do not remove .isolate files, that results in gyp errors (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Project:
chromium
Visibility:
Public.

Description

unbundle: do not remove .isolate files, that results in gyp errors BUG=none R=maruel@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/linux/unbundle/remove_bundled_libraries.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 4 months ago (2014-08-08 15:26:28 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-08 19:12:56 UTC) #2
M-A Ruel
lgtm
6 years, 4 months ago (2014-08-09 00:50:05 UTC) #3
Paweł Hajdan Jr.
6 years, 4 months ago (2014-08-11 09:56:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 288682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698