Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/browser/views/bookmark_bar_view.h

Issue 454010: Makes the chevron throb after a user sync'ed his bookmarks (if the overflow m... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/bookmark_bar_view.h
===================================================================
--- chrome/browser/views/bookmark_bar_view.h (revision 32611)
+++ chrome/browser/views/bookmark_bar_view.h (working copy)
@@ -207,6 +207,11 @@
// Maximum size of buttons on the bookmark bar.
static const int kMaxButtonWidth;
+ // If a button is currently throbbing, it is stopped. If immediate is true
+ // the throb stops immediately, otherwise it stops after a couple more
+ // throbs.
+ void StopThrobbing(bool immediate);
+
// If true we're running tests. This short circuits a couple of animations.
static bool testing_;
@@ -396,15 +401,12 @@
// visible, this returns GetBookmarkButtonCount().
int GetFirstHiddenNodeIndex();
- // If the bookmark bubble is showing this determines which view should throb
- // and starts it throbbing. Does nothing if bookmark bubble isn't showing.
- void StartThrobbing();
+ // This determines which view should throb and starts it
+ // throbbing (e.g when the bookmark bubble is showing).
+ // If |overflow_only| is true, start throbbing only if |node| is hidden in
+ // the overflow menu.
+ void StartThrobbing(const BookmarkNode* node, bool overflow_only);
- // If a button is currently throbbing, it is stopped. If immediate is true
- // the throb stops immediately, otherwise it stops after a couple more
- // throbs.
- void StopThrobbing(bool immediate);
-
// Updates the colors for all the child objects in the bookmarks bar.
void UpdateColors();
@@ -474,9 +476,6 @@
// Animation controlling showing and hiding of the bar.
scoped_ptr<SlideAnimation> size_animation_;
- // If the bookmark bubble is showing, this is the URL.
- GURL bubble_url_;
-
// If the bookmark bubble is showing, this is the visible ancestor of the URL.
// The visible ancestor is either the other_bookmarked_button_,
// overflow_button_ or a button on the bar.
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698