chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 453993002: IsCommandIdEnabled should not fall though if the base did handle the command id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 453993002: IsCommandIdEnabled should not fall though if the base did handle the command id (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « athena/content/render_view_context_menu_impl.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index c0ef40b53a26eece7e9f11407e3c5d9b3df2c41d..80595fdf3ba94f0bd88f8250944b274514d10317 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -953,8 +953,11 @@ void RenderViewContextMenu::AppendProtocolHandlerSubMenu() {

// Menu delegate functions -----------------------------------------------------

bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {

- if (RenderViewContextMenuBase::IsCommandIdEnabled(id))

- return true;

+ {

+ bool enabled = false;

+ if (RenderViewContextMenuBase::IsCommandIdKnown(id, &enabled))

+ return enabled;

+ }

CoreTabHelper* core_tab_helper =

CoreTabHelper::FromWebContents(source_web_contents_);