IsCommandIdEnabled should not fall though if the base did handle the command id

components/renderer_context_menu/render_view_context_menu_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/renderer_context_menu/render_view_context_menu_base.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 232 matching lines @@
   return browser_context_;
 }
 
 bool RenderViewContextMenuBase::AppendCustomItems() {
   size_t total_items = 0;
   AddCustomItemsToMenu(params_.custom_items, 0, &total_items, this,
                        &menu_model_);
   return total_items > 0;
 }
 
-// Menu delegate functions -----------------------------------------------------
-
-bool RenderViewContextMenuBase::IsCommandIdEnabled(int id) const {
+bool RenderViewContextMenuBase::GetCommandIdEnabled(
+    int id,
+    bool* enabled) const {
   // If this command is is added by one of our observers, we dispatch
   // it to the observer.
   ObserverListBase<RenderViewContextMenuObserver>::Iterator it(observers_);
   RenderViewContextMenuObserver* observer;
   while ((observer = it.GetNext()) != NULL) {
-    if (observer->IsCommandIdSupported(id))
-      return observer->IsCommandIdEnabled(id);
+    if (observer->IsCommandIdSupported(id)) {
+      *enabled = observer->IsCommandIdEnabled(id);
+      return true;
+    }
   }
 
   // Custom items.
-  if (IsContentCustomCommandId(id))
-    return IsCustomItemEnabled(id);
+  if (IsContentCustomCommandId(id)) {
+    *enabled = IsCustomItemEnabled(id);
+    return true;
+  }
 
   return false;
 }
 
+// Menu delegate functions -----------------------------------------------------
+
 bool RenderViewContextMenuBase::IsCommandIdChecked(int id) const {
   // If this command is is added by one of our observers, we dispatch it to the
   // observer.
   ObserverListBase<RenderViewContextMenuObserver>::Iterator it(observers_);
   RenderViewContextMenuObserver* observer;
   while ((observer = it.GetNext()) != NULL) {
     if (observer->IsCommandIdSupported(id))
       return observer->IsCommandIdChecked(id);
   }
 
@@ skipping 96 matching lines @@
 }
 
 bool RenderViewContextMenuBase::IsCustomItemChecked(int id) const {
   return IsCustomItemCheckedInternal(params_.custom_items, id);
 }
 
 bool RenderViewContextMenuBase::IsCustomItemEnabled(int id) const {
   return IsCustomItemEnabledInternal(params_.custom_items, id);
 }