Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 453963002: Adding missing Build Version check and @TargetApi annotation. (Closed)

Created:
6 years, 4 months ago by ankit
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding missing Build Version check and @TargetApi annotation. Intent.EXTRA_ALLOW_MULTIPLE is only available in JellyBean MR2 and higher. So added missing check for same. To avoid warning at build added @TargetApi annotation. BUG=401333 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ankit
@miguelg PTAL
6 years, 4 months ago (2014-08-08 12:52:19 UTC) #1
Miguel Garcia
lgtm Thanks for the change! I added Peter in CC since he'll probably want to ...
6 years, 4 months ago (2014-08-08 13:00:49 UTC) #2
ankit
On 2014/08/08 13:00:49, Miguel Garcia wrote: > lgtm > > Thanks for the change! > ...
6 years, 4 months ago (2014-08-08 13:04:37 UTC) #3
Peter Beverloo
On 2014/08/08 13:04:37, ankit wrote: > On 2014/08/08 13:00:49, Miguel Garcia wrote: > > lgtm ...
6 years, 4 months ago (2014-08-08 13:09:19 UTC) #4
ankit
On 2014/08/08 13:09:19, Peter Beverloo wrote: > On 2014/08/08 13:04:37, ankit wrote: > > On ...
6 years, 4 months ago (2014-08-08 13:09:50 UTC) #5
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 4 months ago (2014-08-08 13:09:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/453963002/1
6 years, 4 months ago (2014-08-08 13:10:50 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 14:41:24 UTC) #8
Message was sent while issue was closed.
Change committed as 288358

Powered by Google App Engine
This is Rietveld 408576698